trunk shadow changes: com.unity.ml-agents - #6322
Conversation
to avoid conflicts with latest Unity versions
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
Co-authored-by: OliviaBayley <150163193+OliviaBayley@users.noreply.github.com>
|
|
| using NUnit.Framework; | ||
| using Unity.MLAgents.Sensors; | ||
| using UnityEngine; | ||
| #if !UNITY_EDITOR_WIN |
There was a problem hiding this comment.
This condition is applied to every one of the 41 C# sources under Tests/Editor, including the Public API assembly. Both test assemblies still target the Editor, and the generated Windows validation jobs invoke the editor test suite; with UNITY_EDITOR_WIN defined, those jobs compile no ML-Agents Editor fixtures at all. Consequently Windows CI can pass while all Editor behavior is untested. Restore the suite, or isolate and track only the specific failing tests instead of conditionally removing every fixture.
🤖 Helpful? 👍/👎
|
|
||
| namespace Unity.MLAgents.Tests | ||
| { | ||
| [Ignore("Temporary")] |
There was a problem hiding this comment.
A fixture-level Ignore skips every test in this class on every platform. That includes TestStackedGetCompressedObservationMultiChannel, the only direct coverage found for the four-channel compressed-stacking path described as fixed in this release. CI will therefore no longer validate that path and a regression will be reported as a passing run with skipped tests. Re-enable the fixture (or narrowly skip only a documented failing case) before release.
🤖 Helpful? 👍/👎
a9eda55 to
96bc325
Compare
This PR contains changes made to the
trunkcopy ofcom.unity.ml-agents.tests.Please review the test changes and incorporate them into your test package as appropriate, before your next package release.
If this PR contains unexpected changes, first make sure the PR target branch is set correctly. If not, change it by clicking the pencil icon next to the PR title.
Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.ml-agentsbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.