chore: Address last issues on NGO side (following on N4Ev7.0.0 release) - #4156
chore: Address last issues on NGO side (following on N4Ev7.0.0 release)#4156michalChrobot wants to merge 12 commits into
Conversation
…r solution is made
…ved N4E core package gets released) + added hard dependency on N4E
There was a problem hiding this comment.
💡 Harness Review
The compatibility update fixes the namespace references and introduces a replacement scale bridge, but the bridge loses valid non-uniform parent scale and the unified validation configuration remains pinned to the prior Netcode version.
Reviewed commit 62718d8
🤖 Helpful? 👍/👎
|
/review |
There was a problem hiding this comment.
💡 Harness Review
The unified dependency and compatibility updates are largely coherent, including the replacement scale path and the updated unified test manifest. The CI editor selection, however, still leaves scheduled coverage on the editor versions this change explicitly cannot support.
Reviewed commit 65dc4e4
🤖 Helpful? 👍/👎
| validation_editors: | ||
| default: | ||
| - 6000.7 | ||
| - trunk |
There was a problem hiding this comment.
Changing only default and minimal does not make CI trunk-only: the weekly workflow expands validation_editors.all for package, project, player, and other tests, and that list still contains 6000.7.0a6 and 6000.7. Those released editors retain Netcode for Entities as a core package, the incompatibility this change is avoiding by adding the direct 7.0.0 dependency, so the weekly jobs will either fail resolving the package set or no longer validate the intended dependency. Temporarily make all trunk-only as well (or exclude all-dependent jobs) until the compatible editor release is available.
🤖 Helpful? 👍/👎
There was a problem hiding this comment.
known thing and this is temporary
|
Closing as those changes are covered in #4158 |

Purpose of this PR
Fixes three issues that surface when NGO (unified) builds against Netcode for Entities (N4E) 7.0.0.
N4E 7.0.0 dependency + editor
com.unity.netcode@7.0.0hard dependency and bumpcom.unity.transportto 6.5.0 to match N4E dependency on it (as this is the core transport version that would be used anyway) .Removed API: GhostObject.ApplyPostTransformMatrixScale
Netcode type shadows the Unity.Netcode namespace
Correct NetCode capital C casing
@NoelStephensUnity I'm not sure if you planned to do it in a separate PR but I fixed it here to see if CI will pass otherwise. Feel free to correct those in separate PR and then merge it to this one if you prefer
Disabled more tests for CoreCLR
Previously when trying to update editor manifest with previous NGO release we failed CoreCLR job which was cause by our tests which we need to fix. I disabled them here so we will avoid being ejected from a batch
Jira ticket
N/A
Documentation
N/A
Testing & QA (How your changes can be verified during release Playtest)
Green CI + I will also open projects with latest built editor (trunk) to see if everything works (which will work as a minimal playtest validation before 3.X release)
Up-port
N/A
Backports
N/A