Skip to content

chore: Address last issues on NGO side (following on N4Ev7.0.0 release) - #4156

Closed
michalChrobot wants to merge 12 commits into
develop-3.x.xfrom
addressing-ngo-3-issues
Closed

chore: Address last issues on NGO side (following on N4Ev7.0.0 release)#4156
michalChrobot wants to merge 12 commits into
develop-3.x.xfrom
addressing-ngo-3-issues

Conversation

@michalChrobot

@michalChrobot michalChrobot commented Sep 8, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

Fixes three issues that surface when NGO (unified) builds against Netcode for Entities (N4E) 7.0.0.

N4E 7.0.0 dependency + editor

  • Add com.unity.netcode@7.0.0 hard dependency and bump com.unity.transport to 6.5.0 to match N4E dependency on it (as this is the core transport version that would be used anyway) .
  • CI update to temporarily use trunk only (which doesn't have N4E as core package anymore) in contrast to officialy released editors that do. I'm keeping validation_editors.all as a reminder to correct this once next editor is released

Removed API: GhostObject.ApplyPostTransformMatrixScale

  • N4E removed this in its 6.7.0 non-uniform (3D) scale rework, where the GameObject↔entity transform sync now owns PostTransformMatrix. Re-added as a temporary internal extension over the new model (with a uniform-scale fallback), the three call sites are unchanged. Adds a Unity.Transforms asmdef reference. To be replaced once N4E exposes a supported scale API or other solution is worked on

Netcode type shadows the Unity.Netcode namespace

  • N4E 7.0.0 introduces a Netcode facade type in the shared Unity.Netcode root, so Netcode. inside NGO now binds to the type instead of the namespace. Dropped the redundant Netcode. qualifier at the one code site (was CS0117) and ~22 XML doc crefs. A proper N4E-side rename is tracked separately (the facade is experimental, so no breaking-change process will be required as this is behind experimental define).

Correct NetCode capital C casing
@NoelStephensUnity I'm not sure if you planned to do it in a separate PR but I fixed it here to see if CI will pass otherwise. Feel free to correct those in separate PR and then merge it to this one if you prefer

Disabled more tests for CoreCLR
Previously when trying to update editor manifest with previous NGO release we failed CoreCLR job which was cause by our tests which we need to fix. I disabled them here so we will avoid being ejected from a batch

Jira ticket

N/A

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

Green CI + I will also open projects with latest built editor (trunk) to see if everything works (which will work as a minimal playtest validation before 3.X release)

Up-port

N/A

Backports

N/A

@michalChrobot michalChrobot self-assigned this Sep 8, 2026
…ved N4E core package gets released) + added hard dependency on N4E
@michalChrobot michalChrobot changed the title Added temporary ApplyPostTransformMatrixScale replacement Address latest issues on NGO side (from where N4Ev7.0.0 was released) Sep 8, 2026
@michalChrobot
michalChrobot marked this pull request as ready for review September 8, 2026 09:41
@michalChrobot michalChrobot changed the title Address latest issues on NGO side (from where N4Ev7.0.0 was released) chore: Address latest issues on NGO side (from where N4Ev7.0.0 was released) Sep 8, 2026

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The compatibility update fixes the namespace references and introduces a replacement scale bridge, but the bridge loses valid non-uniform parent scale and the unified validation configuration remains pinned to the prior Netcode version.

Reviewed commit 62718d8

🤖 Helpful? 👍/👎

Comment thread com.unity.netcode.gameobjects/package.json
@michalChrobot michalChrobot changed the title chore: Address latest issues on NGO side (from where N4Ev7.0.0 was released) chore: Address last issues on NGO side (following on N4Ev7.0.0 release) Sep 8, 2026
@michalChrobot

Copy link
Copy Markdown
Member Author

/review

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The unified dependency and compatibility updates are largely coherent, including the replacement scale path and the updated unified test manifest. The CI editor selection, however, still leaves scheduled coverage on the editor versions this change explicitly cannot support.

Reviewed commit 65dc4e4

🤖 Helpful? 👍/👎

Comment thread .yamato/project.metafile
validation_editors:
default:
- 6000.7
- trunk

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

Changing only default and minimal does not make CI trunk-only: the weekly workflow expands validation_editors.all for package, project, player, and other tests, and that list still contains 6000.7.0a6 and 6000.7. Those released editors retain Netcode for Entities as a core package, the incompatibility this change is avoiding by adding the direct 7.0.0 dependency, so the weekly jobs will either fail resolving the package set or no longer validate the intended dependency. Temporarily make all trunk-only as well (or exclude all-dependent jobs) until the compatible editor release is available.

🤖 Helpful? 👍/👎

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

known thing and this is temporary

@michalChrobot

Copy link
Copy Markdown
Member Author

Last correction is due to
image

@michalChrobot

Copy link
Copy Markdown
Member Author

Closing as those changes are covered in #4158

@michalChrobot
michalChrobot deleted the addressing-ngo-3-issues branch September 9, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant