Skip to content

chore: replace DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG#4006

Merged
NoelStephensUnity merged 13 commits into
develop-2.0.0from
chore/replace-development-build
Jun 9, 2026
Merged

chore: replace DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG#4006
NoelStephensUnity merged 13 commits into
develop-2.0.0from
chore/replace-development-build

Conversation

@NoelStephensUnity

@NoelStephensUnity NoelStephensUnity commented Jun 2, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

Working progress (still running various tests)

  • Replacing DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG.
  • Replacing niche DEVELOPMENT_BUILD uses with DEBUG.
  • Bumping back to b1.large for package tests.

Jira ticket

MTT-15104

Changelog

  • Changed: Replaced define usages of DEVELOPMENT_BUILD || UNITY_EDITOR and a few niche uses of DEVELOPMENT_BUILD with DEBUG.

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done
    • Test project link pending

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port is required since this applies to 6000.6+.

Replacing DEVELOPMENT_BUILD || UNITY_EDITOR with DEBUG.
Replacing niche DEVELOPMENT_BUILD uses with DEBUG.

@EmandM EmandM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some files in there that look like accidental adds (PerformanceTestRunInfo, SceneTransitioningBase1). But otherwise this looks like a change we should have done ages ago! Massively simplifies some of those checks!

Comment thread testproject/Assets/Resources/PerformanceTestRunInfo.json Outdated
Comment thread testproject/Assets/Resources/PerformanceTestRunInfo.json.meta Outdated
Removing extra files that didn't need to be included in this PR.
@NoelStephensUnity NoelStephensUnity requested a review from EmandM June 3, 2026 14:16
@michalChrobot

michalChrobot commented Jun 3, 2026

Copy link
Copy Markdown
Member

I queued some trunk jobs to verify (as currently on PRs we use pinned trunk which would pass anyway)

Adding changelog entry
Missed the codegen assembly.
Upgrading our CI ubuntu image to: `package-ci/ubuntu-22.04:v4.86.0`.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 5, 2026 16:15
This reverts commit 2b010d8.
bumping ubuntu to use b1.large (segmentation fault was due to running out of memory).
This reverts commit bd1f004.
This reverts commit 6a434bf.
Switching PR triggers to use trunk as opposed to the pinned trunk.
This reverts commit 5ce1ef4.
Moving pinned trunk up a bit.
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) June 9, 2026 18:21
@NoelStephensUnity NoelStephensUnity merged commit 67e3e1c into develop-2.0.0 Jun 9, 2026
20 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/replace-development-build branch June 9, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants