fix: Add Serializable and NonSerialized attributes#3882
Open
noellie-velez wants to merge 12 commits intodevelop-2.0.0from
Open
fix: Add Serializable and NonSerialized attributes#3882noellie-velez wants to merge 12 commits intodevelop-2.0.0from
noellie-velez wants to merge 12 commits intodevelop-2.0.0from
Conversation
NoelStephensUnity
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
|
|
||
| // Add various types of NetworkVariables | ||
| public NetworkList<ulong> NetworkVariableData1; | ||
| internal NetworkList<ulong> NetworkVariableData1; |
Member
There was a problem hiding this comment.
Why only this one is changed to internal and not the others below?
| /// Partially solves for message loss. Unclamped lerping helps hide this, but not completely | ||
| /// </summary> | ||
| /// <typeparam name="T">The type of interpolated value</typeparam> | ||
| #if NETCODE_UAC1001_CHECKS |
Member
There was a problem hiding this comment.
@NoelStephensUnity so just to double check, how this define would work? Is it something that user would need to set or only on our side?
Collaborator
Author
There was a problem hiding this comment.
This define is being set by us in Runtime/Unity.Netcode.Runtime.asmdef
Collaborator
Author
There was a problem hiding this comment.
But we may just remove it as there is no impact on adding an attribute even when it's not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixing CI compilation error for 6000.5
Jira ticket
N/A
Changelog
N/A
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports