Skip to content

Swift trampoline fixes - #470

Open
aurimasc wants to merge 2 commits into
release/2.5from
swift-trampoline-fixes
Open

Swift trampoline fixes#470
aurimasc wants to merge 2 commits into
release/2.5from
swift-trampoline-fixes

Conversation

@aurimasc

@aurimasc aurimasc commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

https://jira.unity3d.com/browse/UUM-151886
In latest trunk the location of Info.plist file changed in swift trampoline, which broke mobile notification post processor. The fix is trivial - check if file exists and fallback to new location.
Additionally, disable homebrew update as that is causing issues with unity tools we retrieve through it.

Testing:
In general the error was caught by automation.
Tested manually both trampolines to see that info plist entries are found on startup, permission request still works correctly and push notifications do work.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The iOS post-processing change correctly falls back to the Swift trampoline plist location without affecting the project-root paths used by the surrounding processors, and the Swift CI job’s Homebrew settings are scoped to its downloader setup.

Reviewed commit 756655b

🤖 Helpful? 👍/👎

@aurimasc
aurimasc requested review from a team September 9, 2026 08:41
@robertas-unity
robertas-unity requested review from robertas-unity and removed request for a team September 10, 2026 08:35

@robertas-unity robertas-unity left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on 6.6 and 6.7 that Notifications work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants