ADD: Dualsense output report over bluetooth#2436
Draft
MorganHoarau wants to merge 11 commits into
Draft
Conversation
Also applies minor improvements like code name convention.
Collaborator
Author
|
Still WIP because it's a platform agnostic implementation. I'm waiting to receive a MacOS to test on different platform and make sure the native side is working properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ISXB-1477
The Input System always sent the USB output report (ID
0x02) to DualSense controllers regardless of transport (USB or BlueTooth).Complication: Over Bluetooth the controller expects a different output report (ID
0x31, 78 bytes, CRC32-trailed). Sending the USB report over Bluetooth produced garbage output (significant FPS drops, no rumble) and the light bar could not be driven.Resolution:
0x02/ 48 B) or Bluetooth (0x31/ 78 B with computed CRC32) based on the detected transport.reportId=0x01size 78 "simple mode", or0x31) — the HID descriptor isn't populated atFinishSetupon Windows.hidDescriptor.outputReportSize(returns the 547 B max across all vendor reports, causing oversized buffers to be rejected).Depends on the engine-side Windows HID fix (https://github.cds.internal.unity3d.com/unity/unity/pull/110321). Related: ISX-2532, ISXB-787.
Testing status & QA
Manual, physical DualSense on Windows (Bluetooth + USB):
outputReportSizeto a fixed 48 B) - no regression.No performance impact. The change removes the garbage-output path responsible for the FPS drop being fixed; steady-state output is one HID report per call, as before.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
SetMotorSpeedsAndLightBarColor/ output path is DualSense-only; no effect on other devices.Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Documentation Impact
CHANGELOG.mdDocumentation~/SupportedDevices.md: notes 5 and 11 updated (DualSense Bluetooth rumble/light bar now supported; light bar color persists after app exit).IDualShockHaptics.SetLightBarColor: XMLDoc<remarks>noting color persistence.I didn't found other doc page referencing the prior "unsupported over Bluetooth" limitation.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.