Skip to content

NEW: Added Focus Events to Input Event Queue#2365

Draft
VeraMommersteeg wants to merge 13 commits intodevelopfrom
input/add-focus-events-to-queue
Draft

NEW: Added Focus Events to Input Event Queue#2365
VeraMommersteeg wants to merge 13 commits intodevelopfrom
input/add-focus-events-to-queue

Conversation

@VeraMommersteeg
Copy link
Collaborator

@VeraMommersteeg VeraMommersteeg commented Mar 3, 2026

Description

These are the managed changes for the package to introduce a focus event into the event buffer. It no longer listens to the Application.OnFocusChanged and instead changes focus based on the queued event from native. This will help us deal with desync focus state issues to make sure events are being processed in the right state.

Jira tickets:
ISX-2426
ISX-2427

Testing status & QA

Testing done:

  • Ran editor and playmode tests locally
  • Manually tested several Editor Playmode Input Behaviours
  • Built samples as a player and tried several background behaviour settings compared to develop

Testing by QA:

  • General pass against other samples

Overall Product Risks

  • Complexity: Medium - Focus event changes the way events are processed
  • Halo Effect: Low - Most changes are encapsulated to InputManager.cs

Comments to reviewers

I've spend some time cleaning up the OnUpdate a bit, didn't go too crazy and mostly just split up the code a bit in a couple of functions. But since the git diff makes it a bit difficult to see the changes, it might be easier to pull the branch and do a diff that way.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@VeraMommersteeg VeraMommersteeg self-assigned this Mar 3, 2026
@cla-assistant-unity
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VeraMommersteeg VeraMommersteeg changed the title Input/add focus events to queue Added focus events to queue Mar 3, 2026
@VeraMommersteeg VeraMommersteeg changed the title Added focus events to queue NEW: Added Focus Events to Input Event Queue Mar 4, 2026
@ekcoh ekcoh self-requested a review March 4, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant