Fix GLES2 emulated integer functions op_and(), op_or() and op_xor()#45
Open
juj wants to merge 1 commit intoUnity-Technologies:masterfrom
Open
Fix GLES2 emulated integer functions op_and(), op_or() and op_xor()#45juj wants to merge 1 commit intoUnity-Technologies:masterfrom
juj wants to merge 1 commit intoUnity-Technologies:masterfrom
Conversation
…o work properly for negative input values, and optimize to avoid control flow.
fceb3d1 to
3ef11ff
Compare
|
Thanks for this juj, I've pulled it into my local branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GLES2 emulated integer functions op_and(), op_or() and op_xor() to work properly for negative input values, and optimize to avoid control flow.
E.g. before:
After:
Similar transformations to
op_orandop_xor.In case of
op_or, for two one-bit inputsaandb,a | bis implemented as(a+b)/2.In case of
op_xor,a & bis implemented usingint(ab_rem.x != ab_rem.y).