Repository navigation
[TS PBT] Persist direct campaign results with existing evidence - #542
Open
CaelmBleidd wants to merge 2 commits into
Open
CaelmBleidd wants to merge 2 commits into
CaelmBleidd wants to merge 2 commits into
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/pbt-direct-campaign-controls
branch
from
October 15, 2026 22:25
bf5de36 to
71fdab8
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/pbt-campaign-artifact
branch
from
October 15, 2026 22:29
5e7744f to
4880c28
Compare
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct campaign results currently remain in memory. Add
PropertyCampaignRunner.runArtifact, followed byartifact.write(path)andPropertyCampaignArtifact.read(path), to retain and inspect a completed run without executing its engines again.The typed artifact preserves the original
PropertyDefinition, the declared PBT controls and validation reserve, original-property target role, and the existing concrete, symbolic and confirmation results. Their replay/reduction evidence, coverage, observations, candidates, diagnostics and stop phase remain intact. Existing symbolic result/capability types are already portable, so this change makes them serializable rather than introducing parallel snapshot models. The existing UTF-16-safe JSON boundary preserves JavaScript special values and lone surrogates in UTF-8 files. Creation and reading reject mixed property IDs, including IDs inside concrete, symbolic and confirmation results.Source/tool/runtime identities are retained only where the existing property or result provenance records them. Constructor machine options, explicit tsconfig and runtime paths are not attested by this artifact; it is not a complete environment snapshot. Campaign execution and its budget semantics remain those of #540. CLI integration is #545 and the one-way campaign handoff is #355. Cross-round sessions and repeated random PBT generation are outside the current scope; this artifact delivery does not by itself close #354.
Stacked on #540 (
caelmbleidd/pbt-direct-campaign-controls) at71fdab8feabe6b16ccd46a33e1589ee1de320992, including the shared process-shutdown repair from #506.Validation: full module checks passed after updating the shared transport: 195 PBT Kotlin tests, 138 FastCheck Kotlin tests and 186 Node tests, without failures or skips. These include 6 new real run → file → read scenarios, 13 direct-campaign regressions and 18 symbolic-search regressions. The new scenarios cover native violations with actual coverage and observations, native confirmation and reduction, unsupported replay, confirmation timeout with a retained candidate, special values, and rejection of mixed identities. Strict Detekt main/test checks for both changed modules and
git diff --checkpassed.