Repository navigation
[TS PBT] Confirm and shrink named DSL check witnesses - #541
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/pbt-dsl-named-witness
branch
from
October 15, 2026 22:25
80c9c69 to
206929b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated DSL checks could not use external-witness confirmation: their diagnostic companion throws
NamedCheckFailure, which replay classified as an adapter error, and a named target required a separate witness hook. Replay now accepts an explicitly selected declared check through the existing companion, preserving its check ID, actual/expected values and false-versus-exception outcome.Native shrinking and final validation retain the same check, outcome, error name and message. An earlier failed check, rejected precondition, unsupported input or exception before the selected check cannot confirm it. Contextual and hypothesis targets continue to require their exact executable hook binding.
This is a small continuation of #353, stacked on #506 at
0715401d5d973479bc677072322925c47a501c77. The shared process-shutdown repair belongs to that base; this PR retains only the named-check integration. It does not close #353. The caller still selects the check explicitly: symbolic boolean results do not yet carry check identity, and automaticDslPropertyRunnerwiring is deferred. Matching exception messages is conservative and can limit reduction when messages depend on input.Validation:
git diff --checkpassed.No experimental campaign was run.