Repository navigation
[Calls] Separate class search, setup and snapshot timing - #532
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/raw-analysis-phase-accounting
branch
from
October 16, 2026 13:16
4ee4736 to
8634744
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/raw-analysis-phase-accounting
branch
from
October 16, 2026 15:39
926369a to
dd10892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw class diagnostics previously reported setup plus search as
analysisElapsedMillis, counted that sum against the search budget, and omitted the cost of draining saved states. Record search at the machine loop observer boundary, report setup and drain separately, and expose snapshot time within each phase plus journal finalization. The live stage becomesDRAIN_REMAININGafter search stops.analysisElapsedMillisremains the setup+search wall time for compatibility.budgetOverrunMillisnow refers to search only;timingSchemaVersion=1identifies the new accounting. Snapshot timings overlap their respective phases and must not be added to the totals. No search, stop, or journal durability policy changes.Validation: 13 focused Calls tests passed (startup smoke and raw snapshot store), no skips/failures; strict Calls detektMain/detektTest and diff check passed. Broad suites remain for CI/final integration.