Repository navigation
Collect stopped TypeScript inputs through observers - #502
Merged
Merged
Conversation
CaelmBleidd
force-pushed
the
caelmbleidd/pr479-retain-stopped-ts-states
branch
from
October 14, 2026 15:46
34752e5 to
1352314
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/pr479-machine-query-quantum-metrics
branch
from
October 14, 2026 15:46
68bbaf6 to
23f29c8
Compare
Base automatically changed from
caelmbleidd/pr479-machine-query-quantum-metrics
to
main
October 14, 2026 16:16
Preserve the Unit-returning machine loop and shared observer API. Bind an optional TS observer to each analysis queue and let the caller collect unfinished inputs after successful analysis, while retaining unknown-call prefixes before pruning.
CaelmBleidd
force-pushed
the
caelmbleidd/pr479-retain-stopped-ts-states
branch
from
October 14, 2026 16:27
1416a0d to
2b7355b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript analysis discards unfinished inputs when an unknown-call fallback prunes a path or an execution limit leaves states queued. Add an opt-in
TsStoppedStatesObserverthat sends these inputs to a caller-provided consumer, separately from completed witnesses.UMachine.runretains itsUnitcontract. The shared machine observer and machine options retain their existing APIs, and analysis results do not gain a suspended-state list.TsMachineaccepts an observer factory bound to the current selector. Unknown-call prefixes are snapshotted before pruning; reachable runtime-bound states are observed before ordinary witness filtering. After successful analysis, the caller collects the remaining queue while the machine is still open. This preserves stop metadata and avoids treating an exceptionalonMachineStoppedcallback as successful analysis. Queue collection performs no additional execution steps or SAT checks; sink failures remain visible when collection completes.Guarded residuals keep only cached models satisfying their guard, and the step limit stops at the requested count. Void-returning calls use undefined-compatible storage, with a source-level regression test.
Validation after rebasing onto
mainate09199a5a0bb9aeb6eb4eecdcbaf25a3ec16737b: 17 focused TS tests and 21 solver/selector observation tests passed, with no failures or skips. Eight Calls tests also passed with the prepared local consumer migration; that migration remains separate from this PR. Disabling queue extraction made both timeout/step-limit regression checks fail; restoring it made them pass. Whitespace checks passed. These checks establish lifecycle, prefix/model, and fixture integration behavior, not representative real-program coverage.