Repository navigation
[TS] Model Date construction and calendar operations - #444
Merged
Merged
Conversation
CaelmBleidd
marked this pull request as ready for review
October 2, 2026 16:13
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 2, 2026 16:45
c689890 to
46cbcd9
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
2 times, most recently
from
October 7, 2026 23:02
004570f to
a928cc6
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 7, 2026 23:02
46cbcd9 to
9e2c2b2
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 11, 2026 06:51
a928cc6 to
7903bbd
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 11, 2026 06:51
9e2c2b2 to
6c274ff
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 12, 2026 13:26
7903bbd to
625f41f
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 12, 2026 13:26
6c274ff to
3dcce10
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 12, 2026 16:47
8c95ba9 to
ff86b66
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 12, 2026 17:16
3dcce10 to
687d967
Compare
CaelmBleidd
changed the base branch from
caelmbleidd/stdlib-sequences-pr391
to
main
October 12, 2026 17:17
This was referenced Oct 12, 2026
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 13, 2026 09:44
d6be607 to
117a4a0
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-date-pr391
branch
from
October 13, 2026 19:17
117a4a0 to
7d730cd
Compare
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date builtin models execute bundled TypeScript algorithms for numeric constructors, UTC/getters/setters and valueOf. Clock-dependent calls require an explicit fixed clock. Runtime builtin identity preserves project Date shadowing, and timestamp storage is isolated from user properties.
Independent branch against main; carries the small shared model-adapter/dependency API. Required missing or explicit undefined arguments produce NaN; omitted optional setter arguments keep their defaults. Guarded dynamic primitive arguments are supported. Copy construction reads the private timestamp and creates an independent Date.
Validation: 50 focused Date source/artifact, catalog, model execution and SDK identity tests passed. detektMain and detektTest passed on the published head. Fresh GitHub CI remains the broader validation gate.
Review focus: required versus optional argument handling, guarded fake values, timestamp copying and builtin identity. Local-time methods intentionally use UTC; DST, string parsing and arbitrary object coercion remain unsupported.
Rebased onto main 1d2abda while preserving runtime field typing and native typed-array declarations together with private Date timestamp storage. On final 117a4a0, 57 Date, artifact, model-dispatch, runtime-boundary and super-constructor tests passed without skips; Detekt main/test passed. Full CI run 38378469844 passed on this exact head.