Repository navigation
Fix constructor parameter-property local bindings - #437
Merged
CaelmBleidd merged 1 commit intoOct 14, 2026
Merged
Conversation
Contributor
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructor parameter properties currently acquire two locals for the same declaration: the prologue initializes
names, while a constructor loop reads an uninitializednames$1. Resolve the TypeScript Property and Variable symbols of that parameter to one lexical binding, preserving class-field metadata and distinct block-scoped shadows.Validation: all three new frontend regressions fail on the current
neobase and pass with the fix. They cover the constructor loop/property assignment, a real block-scoped shadow, and a later parameter default referring to an earlier parameter property.tsc --noEmitandgit diff --checkpass. Broader validation is left to CI.The normal local license hook currently fails on
jacodb-ets/src/test/kotlin/org/jacodb/ets/test/EtsTsStrictModeTest.kt, which is byte-identical to theneobase and unchanged by this two-file TypeScript fix.