Repository navigation
Lower all array bindings through intrinsic iterators and preserve symbol identity - #435
Merged
CaelmBleidd merged 3 commits intoOct 13, 2026
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array destructuring without a rest element used direct indices, so strings were split into UTF-16 units instead of JavaScript iterator values. Route all array binding patterns through the iterator, preserve defaults and elisions, and close partially consumed iterators using the actual return method and receiver. Return results must be objects; exceptional completion retains the original throw.
Preserve optional ITERATOR symbol provenance in EtsInstanceCallExpr and JSON for intrinsic spread, destructuring and synchronous for-of. Ordinary user methods remain distinct and legacy calls omit the metadata.
Independent against neo. Validation on final 5f32dae: frontend build/typecheck and 63 focused tests passed, including ten native-vs-IR destructuring/IteratorClose cases and five symbol-provenance cases. The original Kotlin symbol roundtrip gate passed; 28 closure/iterator tests additionally passed after updating obsolete index-based expectations, and final full CI passed. No upstream merge is included.