grib2: add support for RRFS aerosol products - #1596
Merged
Merged
Conversation
|
|
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
cambecc
commented
Sep 10, 2026
Contributor
Author
|
Note: I'll squash commits when the review is done (since I suspect more commits will be needed). |
lesserwhirls
approved these changes
Sep 10, 2026
lesserwhirls
left a comment
lesserwhirls
left a comment
Member
There was a problem hiding this comment.
Thank you so much for your contribution! Things look good - I also ran our full test suite on our internal Jenkins server and all tests pass. If you have other changes to this PR that you'd like to make, we can iterate, but otherwise I'd be happy to merge this in!
Contributor
Author
|
Squashed the commits. Also made one slight edit to |
cambecc
marked this pull request as ready for review
September 11, 2026 01:48
Member
|
Excellent - thank you once again for your contribution! It's greatly appreciated. I'll take care of the minor doc updates in a separate PR. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #1595:
Adds support for Product Definition 4.46, ensuring that the aerosol type and size are appended to the Variable's full name and other identifying attributes.
Fixes the existing support for Product Definition 4.48. The aerosol type and size/wavelength are now appended to the full name and other identifying attributes, which fixes an issue where Variables would be dropped due to equality collisions.
With these changes, all RRFS aerosol products can be decoded.
PR Checklist
until ready for review