Skip to content

[pull] master from DefinitelyTyped:master #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
May 7, 2026
+25 −8
Merged

[pull] master from DefinitelyTyped:master #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb9c81
🤖 Merge PR #74872 webidl2 namespace members constant types by @ccouzens
ccouzens May 7, 2026
e52fdc8
🤖 Merge PR #74944 [node] webstreams: restore TransformStream transfor…
Renegade334 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions types/node/node-tests/stream-web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,12 @@ async function queuingStrategySizeReceivesTheChunk() {
assert.deepStrictEqual(result, { done: false, value: "size" });
assert.deepStrictEqual(sizeChunks, ["size"]);
}

// Transformer's `cancel` callback, absent from @types/web
{
new TransformStream({
cancel(reason) {
reason; // $ExpectType any
},
});
}
4 changes: 4 additions & 0 deletions types/node/stream/web.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,16 @@ declare module "node:stream/web" {
signal?: AbortSignal;
}
interface Transformer<I = any, O = any> {
cancel?: TransformerCancelCallback;
flush?: TransformerFlushCallback<O>;
readableType?: undefined;
start?: TransformerStartCallback<O>;
transform?: TransformerTransformCallback<I, O>;
writableType?: undefined;
}
interface TransformerCancelCallback {
(reason: any): void | PromiseLike<void>;
}
interface TransformerFlushCallback<O> {
(controller: TransformStreamDefaultController<O>): void | PromiseLike<void>;
}
Expand Down
6 changes: 2 additions & 4 deletions types/webidl2/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type IDLInterfaceMemberType =

export type IDLInterfaceMixinMemberType = AttributeMemberType | ConstantMemberType | OperationMemberType;

export type IDLNamespaceMemberType = AttributeMemberType | OperationMemberType;
export type IDLNamespaceMemberType = AttributeMemberType | ConstantMemberType | OperationMemberType;

export type IDLTypeDescription = GenericTypeDescription | SingleTypeDescription | UnionTypeDescription;

Expand Down Expand Up @@ -388,15 +388,13 @@ export interface AttributeMemberType extends AbstractBase {

export interface ConstantMemberType extends AbstractBase {
type: "const";
/** Whether its type is nullable. */
nullable: boolean;
/** An IDL Type of the constant that represents a simple type, the type name. */
idlType: IDLTypeDescription;
/** The name of the constant. */
name: string;
/** The constant value */
value: ValueDescription;
parent: CallbackInterfaceType | InterfaceMixinType | InterfaceType;
parent: CallbackInterfaceType | InterfaceMixinType | InterfaceType | NamespaceType;
}

interface AbstractDeclarationMemberType extends AbstractBase {
Expand Down
14 changes: 10 additions & 4 deletions types/webidl2/webidl2-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function logInterfaceMember(member: webidl2.IDLInterfaceMemberType) {

case "const":
member; // $ExpectType ConstantMemberType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType | NamespaceType
logInterfaceMixinMember(member);
break;

Expand Down Expand Up @@ -178,7 +178,7 @@ function logInterfaceMixinMember(member: webidl2.IDLInterfaceMixinMemberType) {

case "const":
member; // $ExpectType ConstantMemberType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType | NamespaceType
logCallbackInterfaceMember(member);
break;

Expand All @@ -205,11 +205,10 @@ function logCallbackInterfaceMember(member: webidl2.IDLCallbackInterfaceMemberTy

case "const":
member; // $ExpectType ConstantMemberType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType | NamespaceType
console.log(member.name);
logIdlType(member.idlType);
logValueDescription(member.value);
console.log(member.nullable);
break;

default:
Expand Down Expand Up @@ -241,6 +240,13 @@ function logNamespaceMember(member: webidl2.IDLNamespaceMemberType) {
console.log(member.name);
console.log(member.special, member.readonly, member.inherit);
break;
case "const":
member; // $ExpectType ConstantMemberType
member.parent; // $ExpectType CallbackInterfaceType | InterfaceMixinType | InterfaceType | NamespaceType
console.log(member.name);
logIdlType(member.idlType);
logValueDescription(member.value);
break;

default:
member; // $ExpectType never
Expand Down