Skip to content

📝 CodeRabbit Chat: Implement requested code changes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai wants to merge 1 commit into from
Closed

📝 CodeRabbit Chat: Implement requested code changes #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/atomvm_spectrometer_tests.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,9 @@ parse_filter_args_multiple_csv_test_() ->
parse_filter_args_invalid_min_repos_test_() ->
{"returns error for invalid --min-repos", fun() ->
{error, Msg} = atomvm_spectrometer:parse_args([
)
"filter", "results.csv", "--min-repos", "abc"
]),
?assert(string:str(Msg, "Invalid") > 0)
end}.

parse_supported_args_capitalized_module_no_prefix_test_() ->
Expand Down Expand Up @@ -549,8 +551,10 @@ parse_supported_args_unknown_flag_test_() ->
end}.

%% =============================================================================
%% parse_filter_args/2 tests
%% parse_filter_args/2 additional tests
%% =============================================================================

parse_filter_args_unknown_option_test_() ->
{"returns error for flag-shaped option where csv_file expected", fun() ->
{error, Msg} = atomvm_spectrometer:parse_args([
"filter", "--unknown-flag"
Expand Down
8 changes: 5 additions & 3 deletions test/spectrometer_elixir_tests.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ is_elixir_module_name_lowercase_test() ->
?assertEqual(false, spectrometer_utils:is_elixir_module_name("GPIO")),
?assertEqual(false, spectrometer_utils:is_elixir_module_name("MyModule")).

parse_query_string_mapset_test() ->
?assertEqual(
{ok, 'Elixir.MapSet', new, 0},
spectrometer_atomvm:parse_query_string("Elixir.MapSet:new/0")
).



Expand Down Expand Up @@ -157,9 +162,6 @@ is_elixir_module_name_lowercase_test() ->



{ok, 'Elixir.MapSet', new, 0},
spectrometer_atomvm:parse_query_string("Elixir.MapSet:new/0")
).

%% =============================================================================
%% filter_modules_by_type/2 tests (new function in this PR)
Expand Down
6 changes: 1 addition & 5 deletions test/spectrometer_updater_tests.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,14 +1499,10 @@ scan_exavmlib_dir_test_() ->




),
?assertEqual(Acc, Result)
end}.

%% =============================================================================
%% parse_release_branch_version/1 direct tests (renamed from parse_release_version in this PR)
%% =============================================================================


parse_release_branch_version_basic_test_() ->
{"parses major.minor version string into tuple", fun() ->
Expand Down
Loading