Skip to content

Unify semantic legend params.#727

Open
gepcel wants to merge 14 commits into
Ultraplot:mainfrom
gepcel:testsemanticlegend
Open

Unify semantic legend params.#727
gepcel wants to merge 14 commits into
Ultraplot:mainfrom
gepcel:testsemanticlegend

Conversation

@gepcel
Copy link
Copy Markdown
Collaborator

@gepcel gepcel commented May 18, 2026

Addresses #726

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 95.82245% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/legend.py 89.26% 5 Missing and 11 partials ⚠️

📢 Thoughts on this report? Let us know!

@gepcel
Copy link
Copy Markdown
Collaborator Author

gepcel commented May 19, 2026

Try something.

pre-commit.ci autofix

@gepcel gepcel added the Wait Suspending current issue until further notice label May 19, 2026
@gepcel
Copy link
Copy Markdown
Collaborator Author

gepcel commented May 20, 2026

There are at least two existing issues with this PR:

  1. Arguments can be passed through full names, aliases, or within handle_kw, kwargs and other parameters, which occasionally causes argument value overrides.
  2. Regarding color-related parameters such as color, fc, ec and so on, I have not yet figured out a clear judgment logic. It should determine whether a value is a list of color values lthat should be applied separately to each entry, or whether list-type tuple values need to be converted into a single unified value. I suspect Ultraplot already has built-in logic to handle this judgment, but I have not located the relevant code implementation yet.

@gepcel gepcel added the help wanted Extra attention is needed label May 20, 2026
gepcel added 2 commits May 20, 2026 16:11
pass edgecolor ends up mulple args. Try unifying.
@gepcel gepcel force-pushed the testsemanticlegend branch from 28198b2 to c876eb0 Compare May 20, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed Wait Suspending current issue until further notice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant