Skip to content

fix: show 'NOT Activated' instead of 'Activated' for failed pre-install checks#962

Merged
superdav42 merged 2 commits intomainfrom
chore/fix-preinstall-check-labels
Apr 28, 2026
Merged

fix: show 'NOT Activated' instead of 'Activated' for failed pre-install checks#962
superdav42 merged 2 commits intomainfrom
chore/fix-preinstall-check-labels

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

@superdav42 superdav42 commented Apr 27, 2026

Summary

  • Pre-install checks displayed "Activated x" when a requirement failed, which was confusing — it read as if the item IS activated with a mysterious x mark
  • Added fail_condition keys to plugin requirement entries so failed checks now show "NOT Activated x", "NOT Network Activated x", etc., making it obvious the x indicates a problem
  • Template falls back to condition if fail_condition is not set, so existing/third-party usage is unaffected

Resolves the UX confusion where a red "Activated x" label appeared to contradict itself.


aidevops.sh v3.13.3 plugin for OpenCode v1.3.17 with claude-opus-4-6 spent 21m and 1,603 tokens on this as a headless worker.

Summary by CodeRabbit

  • Bug Fixes
    • Improved setup wizard requirements table to display specific failure messages. The setup wizard now shows distinct messaging for unmet requirements such as WordPress Multisite, Ultimate Multisite, and WordPress Cron, providing clearer feedback about why conditions are not met.

@superdav42 superdav42 added the origin:interactive Created by interactive user session label Apr 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0fa6a55-c919-4364-bee3-c5ac13668eaa

📥 Commits

Reviewing files that changed from the base of the PR and between 84f370e and 4aaf8f1.

📒 Files selected for processing (2)
  • inc/admin-pages/class-setup-wizard-admin-page.php
  • views/wizards/setup/requirements_table.php

📝 Walkthrough

Walkthrough

The setup wizard's requirements table now displays context-specific messaging based on requirement pass/fail status. Three requirements in the data structure were given explicit fail_condition labels, and the template now conditionally displays either the passing condition or failing condition text.

Changes

Cohort / File(s) Summary
Requirements Data Structure
inc/admin-pages/class-setup-wizard-admin-page.php
Added fail_condition labels to three requirement entries: WordPress Multisite, Ultimate Multisite (network activated), and WordPress Cron (activated).
Requirements Table View
views/wizards/setup/requirements_table.php
Modified condition cell rendering to display fail_condition when requirement fails, with fallback to condition if unavailable; displays condition when requirement passes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Three new fail conditions hop into place,
A rabbit reviews the table with grace,
When requirements stumble, the message is clear,
Pass or fail states, now both appear here! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing misleading labels in pre-install checks by showing 'NOT Activated' instead of 'Activated' for failed requirements.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-preinstall-check-labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Performance Test Results

Performance test results for 8170d50 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 42 (+1 / +2% ) 37.88 MB 863.50 ms 153.50 ms 1066.00 ms 2126.00 ms (+98.00 ms / +5% ) 2022.40 ms (+77.75 ms / +4% ) 83.25 ms (-5.70 ms / -7% )
1 56 49.03 MB 958.50 ms (+40.00 ms / +4% ) 143.50 ms (+4.00 ms / +3% ) 1100.00 ms (+43.50 ms / +4% ) 2108.00 ms (+68.00 ms / +3% ) 2027.20 ms (+65.15 ms / +3% ) 79.75 ms (+1.65 ms / +2% )

@superdav42 superdav42 merged commit 869b7ac into main Apr 28, 2026
6 of 7 checks passed
@github-actions
Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:interactive Created by interactive user session

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant