fix: continue execution when initial resume wait times out - #161
Open
andreitava-uip wants to merge 3 commits into
Open
fix: continue execution when initial resume wait times out#161andreitava-uip wants to merge 3 commits into
andreitava-uip wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR changes debug runtime behavior so that if the initial “wait for resume” times out, execution continues (instead of faulting), and adds a regression test for that scenario.
Changes:
- Update
UiPathDebugRuntime._stream_and_debugto log a warning and proceed when the initial resume wait times out. - Add an async test verifying a timeout on the initial resume wait still results in successful execution and emits completion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_debugger.py | Adds coverage for continuing execution when the initial resume wait times out. |
| src/uipath/runtime/debug/runtime.py | Changes timeout handling to proceed rather than yield a faulted result and exit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Intermittent job failures on resume. A debug run starts paused, waiting up to 60s for a resume command from the debug bridge. When the SignalR client disconnects and never sends one,
UiPathDebugRuntime._stream_and_debugyielded aFAULTEDresult and returned, failing the job:Fix
On the initial resume-wait timeout, log the warning and fall through into the normal streaming loop instead of faulting — the run proceeds unattended with the options it was launched with. The explicit-quit path (
UiPathDebugQuitError) is unchanged.Testing
Added
test_debug_runtime_continues_when_initial_resume_wait_times_out; the timeout is simulated by havingwait_for_resumeraiseasyncio.TimeoutError, whichasyncio.wait_forpropagates identically. Full suite passes.