fix(evals): Recursive float comparison across evaluators#1370
Merged
andrei-rusu merged 1 commit intomainfrom Feb 25, 2026
Merged
fix(evals): Recursive float comparison across evaluators#1370andrei-rusu merged 1 commit intomainfrom
andrei-rusu merged 1 commit intomainfrom
Conversation
github-actions
bot
added
test:uipath-langchain
AndreiDumitrescu26
approved these changes
Feb 25, 2026
andrei-rusu
force-pushed
the
fix/andreiru/float_comparison_across_evaluators
branch
from
25fe1b6 to
2fa3de5
Compare
AndreiDumitrescu26
approved these changes
Feb 25, 2026
andrei-rusu
deleted the
fix/andreiru/float_comparison_across_evaluators
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an extra, this PR also makes ExactMatch no longer rely on string comparison for everything. For example, dict comparison would be handled by dict comparison rules, avoiding false negatives w.r.t. key orders.