fix(evals): Exact match float int mismatch#1365
Merged
andrei-rusu merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
daeeba0 to
2c5a528
Compare
AndreiDumitrescu26
approved these changes
Feb 24, 2026
2c5a528 to
f3224b7
Compare
f4c6b30 to
73395d3
Compare
Member
|
This fix doesn't cover the case where When actual_output = str({"result": 27.0}) # "{'result': 27.0}"
expected_output = str({"result": 27}) # "{'result': 27}"
float("{'result': 27.0}") # ValueError → falls back to string comparison → mismatchThe Repro: any evaluator JSON with The fix probably needs deep structural comparison with numeric normalization for the dict case, e.g. recursively normalizing int/float before comparing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.