feat(apollo-wind): enable React Compiler#257
Draft
SreedharAvvari wants to merge 1 commit intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency ReviewThe following issues were found:
License Issuespackages/apollo-wind/package.json
OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull request overview
Enables the React Compiler for @uipath/apollo-wind by wiring babel-plugin-react-compiler into the library (Rslib/Rsbuild) build pipeline and Storybook’s Vite pipeline, plus refactorings intended to remove render-phase mutations that cause compiler bailouts.
Changes:
- Add React Compiler Babel plugin to
@uipath/apollo-windRslib build via@rsbuild/plugin-babel. - Refactor
MetadataFormandFormDesignerto avoid render-phase ref mutations (compiler compatibility). - Enable React Compiler in Storybook Vite config for more representative
react-scanprofiling.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks new build/tooling deps (React Compiler plugin, Rsbuild Babel plugin, Vite React plugin). |
| packages/apollo-wind/src/components/forms/metadata-form.tsx | Moves ref updates into effects to avoid render-phase mutations. |
| packages/apollo-wind/src/components/forms/form-designer.tsx | Replaces mutable useMemo object pattern with useRef + effect sync. |
| packages/apollo-wind/rslib.config.ts | Adds @rsbuild/plugin-babel and injects babel-plugin-react-compiler. |
| packages/apollo-wind/package.json | Adds devDependencies needed for compiler in build + Storybook. |
| packages/apollo-wind/.storybook/main.ts | Adds React Compiler plugin to Storybook’s Vite config. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
4530021 to
c26bf43
Compare
📦 Dev Packages
|
c26bf43 to
6c59238
Compare
6c59238 to
8ea14be
Compare
8ea14be to
f606fe6
Compare
f606fe6 to
12c9d5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
babel-plugin-react-compilerto the Rslib build pipeline for@uipath/apollo-windChanges
add react compiler in annotation modepluginBabelwithcompilationMode: 'annotation'move ref assignments to useEffectvaluesRef.currentandcontextRef.currentrender-phase mutations in MetadataFormconvert mutable useMemo to useRefcurrentTypeRefmutable object pattern in FormDesignerenable react compiler for all componentsenable react compiler in storybook@vitejs/plugin-reactwith compiler to Storybook's Vite configVerification
"use no memo"opt-outs neededStorybook template
Consumption in flow-workbench