Repository navigation
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
erogluorhan
self-requested a review
November 10, 2026 20:19
erogluorhan
approved these changes
Nov 10, 2026
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
Thanks for taking care of this! All looks good to me.
erogluorhan
reviewed
Nov 10, 2026
| @@ -520,12 +520,13 @@ | |||
| "source": [ | |||
Member
There was a problem hiding this comment.
Line #9. height=500,
Realized this after approving the PR that neither of the height or width is equal to the previously used fig_size value of. 250. That was the case for the first plot above that you made, i.e. height == 400 == fig_size.
Reply via ReviewNB
Contributor
Author
There was a problem hiding this comment.
Checking on /glade and refreshing figures needed. Feel free to push.
erogluorhan
self-requested a review
November 10, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1884
The 3.75km MPAS example still called
UxDataArray.plot.rasterize(method="point"), which no longer exists. The cells now useplot.points(rasterize=True, ...), the same face-center point rasterization the old call did, withfig_sizereplaced bywidth/height.Also drops the stale
.rasterize()mention in the E3SM example and fixesUxDataArray.polygons()toUxDataArray.plot.polygons()in the plotting guide.