Skip to content

Avoid tiny numpy arrays in numba: optimize geometry.py #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sevans711 wants to merge 4 commits into
base: main
Choose a base branch
from
+151 −190
Draft

Avoid tiny numpy arrays in numba: optimize geometry.py #1790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3c4e22
clean up pole_point_inside_polygon
Sevans711 Sep 25, 2026
d197bef
optimize _triangle_line_intersection
Sevans711 Sep 25, 2026
9aae0a9
dont _get_cartesian_face_edge_nodes for 1 triangle
Sevans711 Sep 25, 2026
72b3e0a
forgot pre-commit ruff formatting
Sevans711 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions uxarray/grid/bounds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ def _construct_face_bounds(
):
"""Compute the bounds of a single face."""
# Check if face_edges contains pole points
has_north_pole = pole_point_inside_polygon(1, face_edges_xyz, face_edges_lonlat)
has_south_pole = pole_point_inside_polygon(-1, face_edges_xyz, face_edges_lonlat)
has_north_pole = pole_point_inside_polygon(1, face_edges_xyz)
has_south_pole = pole_point_inside_polygon(-1, face_edges_xyz)

# Initialize face_latlon_array with INT_FILL_VALUE
face_latlon_array = np.full((2, 2), np.nan, dtype=np.float64)
Expand Down
Loading
Loading