Stop echoing caller file paths in recommended_next_steps - #99
Merged
Conversation
Every suggested call interpolated the caller's own absolute grid and data paths back into the string, so a four-step list repeated the same path four times; those echoed paths alone were 28-36% of an inspection result. Steps now name a caller-supplied value by parameter name, spell out only values the server discovered, and bracket what is still missing, which shrinks results 18-34% and raises the computed-answer share from 25-49% to 39-61%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every suggested next step interpolated the caller's own absolute grid and data paths back into the string, so a four-step list repeated the same path four times and those echoed paths alone ran 28-36% of an inspection result. Steps now name a caller-supplied value by parameter name, spell out only values the server discovered, and bracket what is still missing, which shrinks results 18-34% and raises the computed-answer share from 25-49% to 39-61%. Closes #83.