[ISSUE-7, 10] Moved all model-specific defaults from Global.h to appropriate model classes

[CodersRepo]

Closes #7 #10

Description

Checklist (Mandatory for new features)

• Added Documentation
• Added Unit Tests

Testing (Mandatory for all changes)

• GPU Test: test-medium-connected.xml Passed
• GPU Test: test-large-long.xml Passed

[Copilot]

Pull request overview

This PR refactors the simulator’s neuroscience models to remove model-specific default constants from Simulator/Utils/Global.h and place them into the owning neuron/synapse classes, improving encapsulation and addressing inconsistencies noted in #7 and #10.

Changes:

• Moved IF neuron default parameters from Global.h into AllIFNeurons (static constexpr).
• Moved spiking synapse defaults (tau, U, delay weight) into AllSpikingSynapses and updated host/GPU code paths to reference them.
• Removed the corresponding #define DEFAULT_* macros from Global.h.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Simulator/Vertices/Neuro/AllIFNeurons.h	Adds static constexpr IF neuron defaults to the model class.
Simulator/Vertices/Neuro/AllIFNeurons.cpp	Switches neuron initialization to use AllIFNeurons::DEFAULT_* values.
Simulator/Utils/Global.h	Removes model-specific default macros from the global header.
Simulator/Edges/Neuro/AllSynapsesDeviceFuncs_d.cpp	Updates CUDA device-side synapse creation defaults to use AllSpikingSynapses::DEFAULT_* and adds required include.
Simulator/Edges/Neuro/AllSpikingSynapses.h	Introduces static constexpr defaults for spiking synapses.
Simulator/Edges/Neuro/AllSpikingSynapses.cpp	Uses the new AllSpikingSynapses::DEFAULT_tau in edge creation.
Simulator/Edges/Neuro/AllDynamicSTDPSynapses.cpp	Replaces DEFAULT_U usage with AllSpikingSynapses::DEFAULT_U.
Simulator/Edges/Neuro/AllDSSynapses.cpp	Replaces DEFAULT_U usage with AllSpikingSynapses::DEFAULT_U.
Contributors.md	Adds a 2026 entry.

Comments suppressed due to low confidence (2)

Simulator/Edges/Neuro/AllSynapsesDeviceFuncs_d.cpp:120

• In createSpikingSynapse(), the switch(type) has a default: break; and then tau/delay are used to compute decay/totalDelay. If an unexpected edgeType reaches here, this will use uninitialized values (UB) on the device. Consider asserting in the default case (like the CPU path does) or initializing tau/delay to safe defaults before the switch.

   allEdgesDevice->tau_[iEdg] = AllSpikingSynapses::DEFAULT_tau;

   BGFLOAT tau;
   switch (type) {
      case edgeType::II:

Simulator/Edges/Neuro/AllSynapsesDeviceFuncs_d.cpp:267

• In createSTDPSynapse(), the switch(type) has a default: break; but tau/delay are used immediately afterwards to compute decay/totalDelay. If type is outside {II, IE, EI, EE}, this will use uninitialized values on the device. Recommend asserting in the default branch or setting tau/delay defaults before the switch.

   allEdgesDevice->tau_[iEdg] = AllSpikingSynapses::DEFAULT_tau;

   BGFLOAT tau;
   switch (type) {
      case edgeType::II:

[stiber]

This is kind of tricky. I'll allow it 😀, as we eventually want to move to our own set of exceptions, but that issue hasn't risen to the top yet.

[stiber]

This is just a comment. You can just resolve it and merge, I believe.