Repository navigation
test: verify correct contact email - #2
Open
marcospampi wants to merge 2 commits into
Open
marcospampi wants to merge 2 commits into
marcospampi wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Helias
reviewed
Nov 13, 2026
| @@ -0,0 +1,11 @@ | |||
| import re | |||
|
|
||
| from playwright.sync_api import Page, expect | ||
|
|
||
| def test_contact_email(page: Page): |
Member
There was a problem hiding this comment.
manca il tipo di ritorno, ex def test_contact_email(page: Page) -> None:
| from playwright.sync_api import Page, expect | ||
|
|
||
| def test_contact_email(page: Page): | ||
| page.goto('/contact') |
Member
There was a problem hiding this comment.
qui usi i tab al posto di 4 spazi, e mancano il newline a fine file e la seconda riga vuota prima della def, puoi lanciare black tests/test_contact_email.py
| contact_email = page.get_by_test_id('contact-email') | ||
|
|
||
| expect(contact_email).to_have_text('student.office@example.com') | ||
| expect(contact_email).to_have_url('mailto:student.office@example.com') No newline at end of file |
Member
There was a problem hiding this comment.
to_have_url c'è solo su expect(page), su un locator il test va in AttributeError, per il link puoi usare to_have_attribute("href", "mailto:student.office@example.com")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.