Skip to content

fix(ui5-table): set "More actions" tooltip on row action overflow button #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborjinik merged 1 commit into from
Aug 7, 2026
Merged

fix(ui5-table): set "More actions" tooltip on row action overflow button #13895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/main/cypress/specs/TableRowActions.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ describe("TableRowActions", () => {
cy.get("@actions").eq(0).as("overflowButton");
cy.get("@overflowButton").should("have.attr", "ui5-button");
cy.get("@overflowButton").and("have.attr", "icon", "overflow");
cy.get("@overflowButton").and("have.attr", "tooltip", "More actions");
cy.get("@overflowButton").shadow().find("button").should("have.attr", "title", "More actions");
cy.get("@actions").eq(1).should("have.attr", "name", "actions-1");

cy.get("@overflowButton").realClick();
Expand Down
6 changes: 5 additions & 1 deletion packages/main/src/TableRow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import type Button from "./Button.js";
import type { UI5CustomEvent } from "@ui5/webcomponents-base";
import type { Slot, DefaultSlot } from "@ui5/webcomponents-base/dist/UI5Element.js";
import {
TABLE_ROW_MULTIPLE_ACTIONS, TABLE_ROW_SINGLE_ACTION,
TABLE_ROW_MULTIPLE_ACTIONS, TABLE_ROW_SINGLE_ACTION, TABLE_ROW_OVERFLOW_BUTTON,
} from "./generated/i18n/i18n-defaults.js";

/**
Expand Down Expand Up @@ -208,6 +208,10 @@ class TableRow extends TableRowBase<TableCell> {
});
}

get _overflowButtonTooltip() {
return TableRowBase.i18nBundle.getText(TABLE_ROW_OVERFLOW_BUTTON);
}

get _flexibleActions() {
const flexibleActions = this.actions.filter(action => !action.isFixedAction());
const fixedActionsCount = this.actions.length - flexibleActions.length;
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/TableRowTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default function TableRowTemplate(this: TableRow, ariaColIndex: number =
<Button id="overflow"
icon={iconOverflow}
design={ButtonDesign.Transparent}
tooltip={this._overflowButtonTooltip}
onClick={this._onOverflowButtonClick}
></Button>
}
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,8 @@ TABLE_ROW_ACTIONS=Row Actions
TABLE_ROW_SINGLE_ACTION=1 row action available
#XACT: Screenreader announcement when several actions are available
TABLE_ROW_MULTIPLE_ACTIONS={0} row actions available
#XTOL: Tooltip of the overflow button that reveals additional row actions
TABLE_ROW_OVERFLOW_BUTTON=More actions
#XACT: ARIA description for the row action navigation
TABLE_NAVIGATION=Navigation
#XTOL: Tooltip for the AI button in the column header to indicate that the column is generated by AI
Expand Down
Loading