fix(ui5-dialog): clamp min-width and min-height to viewport at high zoom levels#13438
Open
tsanislavgatev wants to merge 1 commit intomainfrom
Open
fix(ui5-dialog): clamp min-width and min-height to viewport at high zoom levels#13438tsanislavgatev wants to merge 1 commit intomainfrom
tsanislavgatev wants to merge 1 commit intomainfrom
Conversation
…oom levels At 200% browser zoom, rem-based min-width (20rem) can exceed the 90% max-width constraint, causing the dialog to overflow the viewport and become unusable on small or zoomed screens. Use CSS min() to cap min-width and min-height against 90vw/90vh so the dialog always fits within the visible area regardless of zoom level. Fixes #11715
Collaborator
|
🚀 Deployed on https://pr-13438--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 200% browser zoom, rem-based min-width (20rem) can exceed the 90% max-width constraint, causing the dialog to overflow the viewport and become unusable on small or zoomed screens.
Use CSS min() to cap min-width and min-height against 90vw/90vh so the dialog always fits within the visible area regardless of zoom level.
Fixes #11715