feat(ui5-notification-list-item, ui5-tab): add semantic click event#13373
Open
tsanislavgatev wants to merge 6 commits intomainfrom
Open
feat(ui5-notification-list-item, ui5-tab): add semantic click event#13373tsanislavgatev wants to merge 6 commits intomainfrom
tsanislavgatev wants to merge 6 commits intomainfrom
Conversation
tsanislavgatev
force-pushed
the
click-nli
branch
from
68c9216 to
4d43265
Compare
Collaborator
|
🚀 Deployed on https://pr-13373--ui5-webcomponents-preview.netlify.app |
tsanislavgatev
requested review from
GDamyanov,
MapTo0,
dobrinyonkov and
ilhan007
Member
TeodorTaushanov
left a comment
TeodorTaushanov
left a comment
There was a problem hiding this comment.
Looks good to me. Let’s wait for the other teams to review.
dobrinyonkov
approved these changes
Apr 27, 2026
Contributor
dobrinyonkov
left a comment
dobrinyonkov
left a comment
There was a problem hiding this comment.
approved from List side
nikoletavnv
reviewed
Apr 29, 2026
Contributor
nikoletavnv
left a comment
nikoletavnv
left a comment
There was a problem hiding this comment.
I would suggest for 1 test per component where the new click event details are propagated. Otherwise the change is working in the input components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotificationListItem overrode both
_onclickandfireItemPresswithout calling super, bypassing the ListItemBase click event added
in #13315. Both methods now call
stopPropagationon the nativeevent and fire the semantic
clickCustomEvent with{ item, originalEvent }.Tab receives its own
clickevent fired by TabContainer after asuccessful tab selection, carrying
{ tab, originalEvent }soconsumers can distinguish programmatic from user-initiated selection.
Add a semantic
clickCustomEvent that fires on both mouse/tap andkeyboard (Enter/Space) activation. It replaces the propagated native
click (via stopPropagation) with a composed CustomEvent that includes
item/tabandoriginalEventin its detail, enabling consumers todistinguish component-level clicks from raw DOM events.
ListItemBase gets the event as the base implementation for all list items.
Tab fires it from TabContainer when a tab is selected.
Fixes #13328