fix(ui5-li): make delete button keyboard accessible in Delete selection mode#13273
Open
fix(ui5-li): make delete button keyboard accessible in Delete selection mode#13273
Conversation
…on mode The delete button was intentionally removed from the tab chain in 2021 (commit 5176954, PR #3290) based on accessibility guidance at the time. This decision has since been reconsidered — UX now requires the button to be keyboard accessible, as the Delete key shortcut alone is not intuitive for most users. Removed tabindex="-1" and data-sap-no-tab-ref from the delete button, making it consistent with the detail button. Tab, Shift+Tab, and F2 now reach the delete button within list items. Fixes #13220 Relates to #2964
Collaborator
|
🚀 Deployed on https://pr-13273--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete button was intentionally removed from the tab chain in 2021 (commit 5176954, PR #3290) based on accessibility guidance at the time.
Removed
tabindex="-1"anddata-sap-no-tab-reffrom the delete button, making it consistent with the detail button. Tab, Shift+Tab, and F2 now reach the delete button within list items.Fixes #13220
Relates to #2964