fix(ui5-popover): close the popover once it is out of the viewport#13200
Open
duygu-rmdn wants to merge 8 commits intomainfrom
Open
fix(ui5-popover): close the popover once it is out of the viewport#13200duygu-rmdn wants to merge 8 commits intomainfrom
duygu-rmdn wants to merge 8 commits intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13200--ui5-webcomponents-preview.netlify.app |
Stoev
reviewed
Mar 12, 2026
| } | ||
|
|
||
| /** | ||
| * Callback invoked when the opener element's intersection changes. |
There was a problem hiding this comment.
Suggested change
| * Callback invoked when the opener element's intersection changes. | |
| * Callback invoked when the opener element's intersection status changes. |
|
|
||
| /** | ||
| * Callback invoked when the opener element's intersection changes. | ||
| * Closes popover when opener is out of view. |
There was a problem hiding this comment.
Suggested change
| * Closes popover when opener is out of view. | |
| * Closes the popover when the opener is no longer visible. |
? no longer visible in the viewport. ?
| } | ||
|
|
||
| /** | ||
| * Stops observing and cleans up the IntersectionObserver. |
There was a problem hiding this comment.
Suggested change
| * Stops observing and cleans up the IntersectionObserver. | |
| * Stops observing the opener element and cleans up the IntersectionObserver instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #13158
After this change is merged, the Popover methods shouldCloseDueToOverflow, shouldCloseDueToNoOpener, and isOpenerOutsideViewport can be removed; however, for traceability purposes, this should be done in a separate change.