refactor(builder): Include component path in versionInfoGenerator logs#1471
Open
RandomByte wants to merge 1 commit into
Open
refactor(builder): Include component path in versionInfoGenerator logs#1471RandomByte wants to merge 1 commit into
RandomByte wants to merge 1 commit into
Conversation
Several verbose and error logs in isBundledWithLibrary reported that a component didn't declare 'sap.app/embeddedBy' or that its reference didn't point to the library, without naming which component was meant. When a build lists multiple embedded components, the message alone doesn't say which one. Include the component path in the remaining log messages, matching the format already used by the error branches. Update the affected assertions in the processor and task tests.
RandomByte
marked this pull request as ready for review
July 22, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several verbose and error logs in
isBundledWithLibrary(versionInfoGenerator) reported that a component didn't declaresap.app/embeddedBy, or that its reference didn't point to the library, without naming which component. When a build lists multiple embedded components, the message alone doesn't say which one.Add the component path to the remaining log messages, matching the format already used by the error branches (
Component '${componentPath}': ...). Tests in the processor and thegenerateVersionInfotask now assert the component path.