chore(PLT-3524): remove orphaned SonarCloud coverage plumbing#167
Merged
Conversation
Removes coverage steps left behind after PR #165 removed the `sonarcloud` job that consumed them: - Dropped `--coverage` flags from test runs - Removed "Merge coverage reports and generate lcov.info" step - Removed "Upload coverage file" step (artifact had zero consumers) - Cleaned up stale "coverage file uploaded" comment The coverage merge/upload steps existed solely to feed the SonarCloud scan, which #165 correctly removed. With nothing consuming the coverage-report artifact, the plumbing is dead weight. Part of the PLT-3524 SonarCloud decommission. Generated by Glean Code Writer
promiseNwafor
added
the
glean-code-writer
glean-github-app-oauth
robespmun
approved these changes
Jul 17, 2026
promiseNwafor
marked this pull request as ready for review
July 17, 2026 11:54
✅ Security Analysis ResultsGreat news! No security issues found in this pull request. Analysis Summary:
💡 Trigger a new security scan by commenting Security analysis powered by Claude Sonnet 4.6 via pr-auditor | Questions? Contact #dx-team or check out this page |
|
🥷 Code experts: robespmun robespmun has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From Glean Code Writer
Follow-up to PR #165 — removes the coverage plumbing that was left behind after the
sonarcloudjob was deleted.PR #165 correctly removed the SonarCloud scan job and config, but left the steps that existed only to feed it:
--coverageflags on test runs (output was unused)These were all part of the chain that generated
lcov.infofor the SonarCloud scan. With the scan gone, they're dead weight.Changes
--coverageflags fromyarn test:unitandyarn test:integration# coverage file uploaded from this versioncommentNet result: the
build-lint-testjob now just runs install → build → lint → unit tests → integration tests, with no leftover Sonar artifacts.Part of PLT-3524 SonarCloud decommission. This cleanup follows the same pattern as purgatory #306 and single-embed #286, which removed their coverage-upload steps in the initial PR.
Testing
🤖 Generated by Glean Code Writer
📝 Chat link - https://app.glean.com/chat/c78bd9fcfe7a4a1d9eb95b520a8fb09f