Skip to content

fix: filter npm warn stderr to unblock Node 24 deploys #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kb-typeform wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: filter npm warn stderr to unblock Node 24 deploys #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/frontend-deploy-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,16 +605,20 @@ jobs:

- name: Deploy to production
run: |
# Remove deprecated npm config env vars inherited from the runner environment.
# npm 10+ (Node 20.17+/Node 22+) emits warnings to stderr for these legacy keys,
# and Jarvis treats any stderr output as a deployment failure.
# Using both UPPER and lower-case forms to cover all platforms.
# Fix for Node 24 / npm 10+: deprecated npm config env vars cause warnings on stderr.
# Yarn 1.x re-injects npm_config_argv into child processes even after unset,
# so we must also filter stderr to prevent Jarvis from treating warnings as failures.
#
# Step 1: Unset known deprecated vars from the shell environment.
unset NPM_CONFIG_ARGV NPM_CONFIG_VERSION_TAG_PREFIX NPM_CONFIG_VERSION_GIT_MESSAGE \
NPM_CONFIG_VERSION_COMMIT_HOOKS NPM_CONFIG__TYPEFORM_REGISTRY 2>/dev/null || true
unset npm_config_argv npm_config_version_tag_prefix npm_config_version_git_message \
npm_config_version_commit_hooks npm_config__typeform_registry 2>/dev/null || true

${{ inputs.deploy-command }}
# Step 2: Run deploy with stderr filtering to catch any remaining npm warnings
# that get re-injected by Yarn 1.x or read from .npmrc.
# This preserves real errors while stripping only "npm warn" lines.
${{ inputs.deploy-command }} 2> >(grep -v "^npm warn " >&2)
env:
# Jarvis debug logging
DEBUG: jarvis
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/frontend-pr-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,15 +521,20 @@ jobs:

- name: Deploy preview
run: |
# Remove deprecated npm config env vars inherited from the runner environment.
# npm 10+ (Node 20.17+/Node 22+) emits warnings to stderr for these legacy keys,
# and Jarvis treats any stderr output as a deployment failure.
# Fix for Node 24 / npm 10+: deprecated npm config env vars cause warnings on stderr.
# Yarn 1.x re-injects npm_config_argv into child processes even after unset,
# so we must also filter stderr to prevent Jarvis from treating warnings as failures.
#
# Step 1: Unset known deprecated vars from the shell environment.
unset NPM_CONFIG_ARGV NPM_CONFIG_VERSION_TAG_PREFIX NPM_CONFIG_VERSION_GIT_MESSAGE \
NPM_CONFIG_VERSION_COMMIT_HOOKS NPM_CONFIG__TYPEFORM_REGISTRY 2>/dev/null || true
unset npm_config_argv npm_config_version_tag_prefix npm_config_version_git_message \
npm_config_version_commit_hooks npm_config__typeform_registry 2>/dev/null || true

${{ inputs.deploy-command }}
# Step 2: Run deploy with stderr filtering to catch any remaining npm warnings
# that get re-injected by Yarn 1.x or read from .npmrc.
# This preserves real errors while stripping only "npm warn" lines.
${{ inputs.deploy-command }} 2> >(grep -v "^npm warn " >&2)
env:
DEBUG: jarvis
GH_TOKEN: ${{ secrets.GH_TOKEN }}
Expand Down
Loading