perf(coverage): collapse is_executable_line grep calls#643
Merged
Chemaclass merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Combine the seven per-pattern grep subshells in bashunit::coverage::is_executable_line into a single combined regex, matched in one grep invocation per line. Each alternation stays self-anchored so the existing semantics (and the existing test suite) hold unchanged. Reporter measured ~3.8x faster coverage generation on slow hardware. Closes #636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #636
Coverage report generation runs
bashunit::coverage::is_executable_lineon every line of every tracked source file. The previous implementation issued up to sevengrepsubshells per line, which dominates runtime on slow shells (e.g. Cygwin on legacy hardware where users observed multi-hour runs).💡 Changes
grepinvocation.donewith redirection/pipe/fd, case patterns, standalone)) are preserved.coverage_executable_test.shsuite passes unchanged.