[bfs2021]

Problem

Fixes #1421

A test file that puts the opening brace on the next line:

function test_dup()
{
  :
}

was not checked for duplicate test functions. Bash keeps only the last definition of a repeated name, so the first test silently never ran.

Root cause

The awk definition matcher in src/helper/discovery.sh required the opening brace on the same line:

/...\(\)[[:space:]]*\{/

A definition whose { sits on the next line never matched, so the duplicate was never recorded.

Fix

After the name() token the pattern now accepts either an opening brace or end of line:

/...\(\)[[:space:]]*(\{|$)/

Same-line definitions keep matching, and the existing field match and name extraction already work on the name() token alone. The duplicate report text is unchanged.

Testing

• New unit test test_check_duplicate_functions_with_the_brace_on_the_next_line in tests/unit/helper/helper_test.sh, next to the existing duplicate-function checks. It fails on main (the check returned 0) and passes with the fix, also asserting the stored detail test_twice (lines 1, 5).
• ./bashunit tests/unit/helper/helper_test.sh — 88 passed, 140 assertions
• ./bashunit tests/unit/runner/discovery_test.sh — 3 passed, 3 assertions
• ./bashunit tests/acceptance/bashunit_duplicate_parallel_test.sh — 4 passed, 8 assertions (parallel and sequential reports, line numbers, no-duplicate file)

Manual fixtures covering both styles in both modes:

[--no-parallel same_line] exit=1  Duplicate functions: test_dup (lines 1, 2)
[--no-parallel next_line] exit=1  Duplicate functions: test_dup (lines 1, 5)
[--parallel same_line]    exit=1  Duplicate functions: test_dup (lines 1, 2)
[--parallel next_line]    exit=1  Duplicate functions: test_dup (lines 1, 5)

[Chemaclass]

thanks!!