Skip to content

Code Review: repair human seed and panel focus - #522

Merged
BunsDev merged 2 commits into
mainfrom
cr-human-seed
Nov 13, 2026
Merged

BunsDev merged 2 commits into
mainfrom
cr-human-seed

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

The person-run Code Review seed lacked the populated data its checklist required, and closing a header Review panel lost keyboard focus. This adds a complete synthetic human-review world and restores Review/Merge Close and scoped Escape focus to the opener in its own split pane, preserving the instructions popover’s Escape behavior.

The actual seed supports a long description, 101 paged comments, checks, an inferred stack, deployment provenance and coherent diffs for every listed PR. Its eleven-file tree is scrollable for D4/D5 without changing totals or patch content. The checklist uses real Settings opt-in and current controls; the session guide records answered decisions. Status and receipts reconcile three separately accepted on-main technical items: #322 is 12/14 and #323 is 11/14, both open.

The initial source 1b2c58b155d188e372b5647c46a5e93f55c46115 failed hosted macOS E2E: 532 passed, 14 skipped and two failed; site/web steps were skipped. Its 2,588 units with 36 skips and complete iPhone suites passed. The moving-head failure is reproduced as a synthetic comparison-provenance race: the fixture now retains the immutable SHA pair, with deterministic files-held and comparison-held Electron cases. The original graphite Markdown ArrowRight failure remains unexplained; all original assertions/deadlines remain, with bounded observation-only diagnostics validated by cancellation and never-resolving-read controls. Original failures, traces and review rulings remain retained in the CI follow-up receipt.

  • Full follow-up pinned-pnpm build and workspace typechecks pass; a separate E2E TypeScript check also passes. Full units pass 2,588 cases with 36 skips, zero failures/cancellations.
  • Complete follow-up E2E exits zero: 532 desktop passes with 17 opt-in skips in 23.2 minutes, eight site passes and four web passes, zero failures/framework retries. Both moving-head orderings, header focus and all three Markdown themes pass. All 855 bound inputs remained frozen; the complete 9,404,804-byte result archive is SHA-256/read verified.
  • The original actual Electron 44.4.5 human-seed/focus procedure and independently preserved portable runtime pass synthetic wide/narrow paging, focus, diffs and independent tree scrolling. All 808 compiled files still match that runtime byte for byte. The portable runtime has 17,124 verified files and 54 internal dependency links; its unopened person-run seed now has its own project/recorder paths. No real provider turn or GitHub product write ran; human Result cells remain blank.
  • The implementation and test follow-up received scoped review. The diagnostic read-budget finding was repaired and validated against a never-resolving renderer observation, preserving the original assertion and native snapshot; original review rulings and the later data-only correction audit are retained in the receipts.

Current signed source is 4029a077b3483c4cfb9f26b078fe9b4d343a7ecc, tree d92f6e798be0711c0563028275b8c1e5eaec9a53, retaining initial source 1b2c58b above protected main 63a64edf2ccbb2a512ee0cc5e7a1c7aeaa1f3638. The independent recovery bundle restores into an empty bare repository, passes full fsck and source-signature verification, and reproduces all fourteen source files plus all 855 bound inputs. Both final receipts pass actual GitHub GFM/offline browser inspection with natural paragraphs and no forced breaks/overflow; all 142 relative links across six Markdown files resolve. Seed and focus repair.

Exact-head source CI passed all twelve checks: 2,588 units with 36 skips, 535 desktop E2E cases with 14 opt-in skips, eight site cases and four web cases, with zero framework retries. Its actual tested merge preview reproduced the source tree. The separately parsed iPhone result bundles contain 65 native passes and 43 ordinary paired-UI passes plus one intentional expected failure, with zero actual failures/skips; source artifacts passed API size/SHA-256 and ZIP verification.

Protected delivery completed on 2026-11-13 at 11:35:55 UTC as signed merge 49f46971836c7dc4cb26e686c46f142b41d10b46, with the exact reviewed/source tree d92f6e798be0711c0563028275b8c1e5eaec9a53. The actual protected run tested that merged SHA: 2,588 units with 36 skips, 535 desktop E2E cases with 14 opt-in skips in 37.9 minutes, eight site cases and four web cases, zero failures/cancellations/framework retries. Both protected result archives are SHA-256/size/ZIP verified. iPhone was intentionally skipped for this merge-group event; its separate source evidence remains simulator evidence. Newly triggered post-merge checks are a separate run and are not being reported as finished here.

State-change panel focus/Escape and filename directional-format display remain demonstrated engineering follow-ups. Human accessibility, live provider/write, physical-device, default activation and release gates retain their full requirements. No issue closure, human acceptance, feature activation or release is claimed. Related: #322, #323, #324, #327.

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 13, 2026 10:14am UTC
modex-app Building Building Preview Nov 13, 2026 10:14am UTC

Request Review

…d scroll

Retain immutable comparison provenance when the synthetic PR head changes, and cover both held parallel reads through the real Electron read service. Keep all Markdown keyboard assertions while adding bounded failure observations.

Record the initial hosted failures, validated diagnostic controls, complete follow-up local qualification and independently preserved human QA runtime without claiming human or protected acceptance.
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 63a64ed cr-human-seed 4029a07 +/-
65% 65% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 49f4697 Nov 13, 2026
13 checks passed
@BunsDev
BunsDev deleted the cr-human-seed branch November 13, 2026 11:35

This branch was successfully deployed

1 active deployment
Preview – modex — 4029a077 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant