Skip to content

fix: scope chat rename intent and verify review revocation - #518

Merged
BunsDev merged 5 commits into
mainfrom
cr8-access-revocation
Nov 13, 2026
Merged

BunsDev merged 5 commits into
mainfrom
cr8-access-revocation

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

After using the title-bar Rename menu, opening a later chat could replay the old command counter, enter editing with its initial New thread title and save that stale title as manual on blur. The title now consumes only newly received menu commands on the mounted chat. A direct regression verifies later-chat title/provenance preservation and fresh menu, double-click and Enter editing.

The Code Review evidence adds actual Electron/IPC accessible-to-revoked cases for 403/404/410, a held context response and unsafe context paths. It verifies that private responses cannot return after denial while an unrelated repository retains its legitimate offline fallback. The optional offline CLI fixture and immediate diagnostic assertions preserve the existing service behavior; Code Review stays hidden by default.

The first hosted run at ec34bd8 failed an existing human-question privacy scan during an atomic temporary-file rename. The follow-up closes the private app before the unchanged scans. Complete local validation then exposed a global Chat details locator ambiguity and, during diagnosis, the title-bar defect above. The corrected accessibility assertions follow the actual keyboard control’s aria-controls relation and retain role/name/content/focus/Escape checks. First failures, diagnostic attempts and the initial stale-renderer build mistake remain retained in the dated receipt.

Signed source 81e54f816b49850f6acdeb1c3f668c7411637309 integrates protected main b6e3026. Fresh build and typecheck pass; full units pass with 2,579 passes, 36 skips and zero failures/cancellations. Full E2E passes 529 desktop cases with 17 explicit opt-in skips in 20.6 minutes, eight site cases and four web cases, with zero failures or retry/flaky annotations. All fourteen Code Review regressions and all six human-question cases pass. Separate installed Claude Code 2.1.323 qualification passes four ordinary checks and two intentional expected-failure controls in 18.9 seconds, using three native starts against a scripted loopback provider. Sampled cleanup confirms the three recorded native PIDs absent and the three provider ports closed. Incoming GH_TOKEN was already absent; this is not a supplied-token native scrub challenge.

The original revocation review correction and both minor follow-up coverage suggestions are addressed. The fresh follow-up review found no Critical or Important code defect. All three new source signatures verify; the full recovery bundle restored into an empty bare repository, passed full fsck and reproduced all nine authored files byte-for-byte. Full E2E and native artifacts are independently byte-verified. All twelve source checks passed, and protected delivery is now verified at 927b443414befe5f4300bb3f3d39af4666032609, whose complete tree exactly matches the qualified source. The literal #327 adversarial/race test item has now been audited clause by clause against that delivered source and the separate installed-CLI evidence. Whole-issue, live-provider, real-write, human/device, release and default-activation acceptance remain separate.

Source CI run 43336427486 passed 2,579 units with 36 skips, 532 desktop cases with fourteen skips in 36.9 minutes, eight site cases in 22.9 seconds and four web cases in 5.0 seconds, with zero failures/cancellations or retry annotations. The fourteen source desktop skips are four live-provider, four local-model native and six installed-CLI Code Review checks; the separate local native qualification above remains distinct. All four source artifacts match API SHA-256 digests and pass ZIP integrity. Actual tested preview b33a4273a96a3eedf85e1f1740acf0c37c56e0ff, parents b6e3026 and 81e54f8, independently reproduces tree 32853cd5fd78046cc3e8e12aac38b7e910916b85. One protected request was accepted as queue entry f7799ddd-c188-468a-9a3b-454a3c815d83, bound to exact source 81e54f8 with bypass_rules false; timeline event 35981260282 independently confirms admission. Signed queue candidate 927b443414befe5f4300bb3f3d39af4666032609 has parent b6e3026 and that same qualified tree. Protected run 43343769795 passed 2,579 units with 36 skips, 532 desktop cases with fourteen skips in 24.9 minutes, eight site cases in 19.3 seconds and four web cases in 3.0 seconds, with zero failures or retry annotations. Both protected artifacts match API SHA-256 digests and pass ZIP integrity. GitHub independently confirms the actual signed merge 927b443 at 2026-11-13 01:47:13 UTC, parent b6e3026, with the same complete tree 32853cd5fd78046cc3e8e12aac38b7e910916b85. All 853 tracked native qualification inputs match actual main byte-for-byte. The protected iPhone job was skipped; no physical-device acceptance or release is inferred. The queue request was sent once.

Verify ready-to-denied reads, later offline fallback and a held context response through real Electron IPC. Add a direct unsafe-path boundary case and retain all initial failures, the controlled negative result and exact qualification limits.
Assert the visible denial and its direct reply before replacing the diagnostic-emitting route with offline mode. Preserve the old-test false negative, controlled RED, exact production restoration and complete corrected E2E results.
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 13, 2026 12:20am UTC
modex-app Ready Ready Preview Nov 13, 2026 12:20am UTC

Request Review

Prevent a previous Rename command from reopening editing on later chat titles and saving a stale initial title. Add a direct regression, follow keyboard-associated details cards, and quiesce private-app writers before privacy scans.

Validation: original-source regression fails; rebuilt focused cases pass 3/3, complete app/question suites pass 22/22, and typecheck passes. Full current-main qualification remains pending before push.
Integrate b6e3026 before fresh full qualification. Git merged without conflicts; the authored TitleBar delta remains the reviewed command-counter guard.
Strengthen the later-chat regression with saved-title/provenance preservation and fresh menu, double-click and Enter editing. Record both addressed review suggestions, original failures and current-main full-suite evidence.

Validation: build/typecheck, 2579 units with 36 skips, 529 desktop cases with 17 skips, 8 site and 4 web pass. Separate installed Claude 2.1.323 native qualification: 4 ordinary passes and 2 intentional expected-failure controls, 3 native starts, unchanged producer inputs and verified retained artifacts. Hosted and protected delivery remain pending.
@BunsDev BunsDev changed the title test: verify Code Review revocation and unsafe path boundaries fix: scope chat rename intent and verify review revocation Nov 13, 2026
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main b6e3026 cr8-access-revocatio... 81e54f8 +/-
65% 65% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 927b443 Nov 13, 2026
13 checks passed
@BunsDev
BunsDev deleted the cr8-access-revocation branch November 13, 2026 01:47

This branch was successfully deployed

1 active deployment
Preview – modex — 81e54f81 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant