Repository navigation
test: qualify native review isolation and failure cleanup - #517
Merged
Merged
Conversation
Drive one explicit Electron review through the installed Claude CLI and a scripted provider, checking hostile context, denied tools and outside reads, scoped environment and one-start process closure. Preserve direct fixture defaults and keep app observations separate from unobserved child diagnostics. Record local native qualification and its first failures; full E2E, independent review and protected delivery remain pending.
Record actual app runtime and viewport in the opt-in fixture, plus the completed default E2E results and explicit skip limits. Keep review and protected delivery pending.
Capture provider observations even when the app callback rejects, retain inputs before shutdown, and close owned resources independently while preserving primary and cleanup errors. Reject unknown process-inspection failures instead of treating them as child absence. Callback, close and process-lookup regressions failed first and now pass their controls. Six focused checks include two intentional expected failures; full build/units and six existing direct native controls pass. Full CR-8 and protected delivery remain open.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects Code Review’s real Electron/main path to the installed Claude CLI and existing scripted provider. One explicit review reads hostile PR context before forbidden tool/outside-read proposals; the test verifies confinement, one start and observed process exit. The shared fixture retains its direct-run defaults.
A fresh independent review found that callback/shutdown errors could discard observations or skip cleanup. One coalesced correction preserves provider data on callback rejection, copies inputs before shutdown, closes resources independently and records primary and cleanup errors separately. Unknown process-inspection failures now fail qualification. The supplied-token coverage limitation remains documented.
Validation on macOS 27.2.1 arm64, Electron 44.4.5 and Claude 2.1.322:
Final-head hosted CI passed all twelve observed source checks. The macOS job passed 2,534 unit tests with 36 skips, 523 desktop E2E tests with 14 explicit skips, eight site tests and four web tests; no framework retry markers were observed. The six opt-in native cases remain explicitly skipped in ordinary CI and are supported by the separate local native receipts above. Source iPhone CI passed, without implying physical-device acceptance. All four CI artifacts were preserved with matching API SHA-256 digests and verified ZIP integrity.
The dated receipt retains source hashes, first failures, runtime/viewport and qualification limits. Full #327 adversarial/race acceptance, live-provider/live-write and human gates remain open. Product behavior, feature defaults and release state are unchanged.
Refs #327.
Protected delivery is complete: signed
fd80cd49155b449bd3ae7fa3bbd39146d80223ce, tree33330d75a7d9cffaee7a5adf2bf52bba7614d645, merged on parentc695072through queue run 43294368140. The actual required macOS job passed 2,576 unit tests with 36 skips, 525 desktop E2E tests with 14 explicit skips, eight site tests and four web tests. Queue iPhone was skipped. Raw logs and both queue artifacts are retained with matching API SHA-256 digests and verified ZIPs; the full merged tree matches an independent merge projection, all four non-status authored files match reviewed source exactly, and the status file includes main integration. The ordinary queue still skips the six opt-in native cases; their local installed-CLI evidence stays separately pinned to source085b4d5. This delivers the test/receipt slice without accepting the full #327 adversarial criterion, live-provider/live-write, human or release gates.