Skip to content

fix(link-toolbar): prevent Enter from submitting during IME composition #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nperez0111 merged 2 commits into from
Jan 27, 2026
+9 −6
Merged

fix(link-toolbar): prevent Enter from submitting during IME composition #2361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74ead8c
fix(link-toolbar): prevent Enter from submitting during IME composition
hanios123 Jan 15, 2026
0795d1c
Added `isComposing` check to all Enter `keydown` handlers that didn't…
matthewlipski Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/extensions/NodeSelectionKeyboard/NodeSelectionKeyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const NodeSelectionKeyboardExtension = createExtension(
// Checks if key press is Enter
if (
event.key === "Enter" &&
!event.isComposing &&
!event.shiftKey &&
!event.altKey &&
!event.ctrlKey &&
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/FilePanel/DefaultTabs/EmbedTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const EmbedTab = <

const handleURLEnter = useCallback(
(event: KeyboardEvent) => {
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
event.preventDefault();
editor.updateBlock(block.id, {
props: {
Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/components/FormattingToolbar/DefaultButtons/FileCaptionButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ export const FileCaptionButton = () => {
editorHasBlockWithType(editor, block.type, {
caption: "string",
}) &&
event.key === "Enter"
event.key === "Enter" &&
!event.nativeEvent.isComposing
) {
event.preventDefault();
editor.updateBlock(block.id, {
Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/components/FormattingToolbar/DefaultButtons/FileRenameButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ export const FileRenameButton = () => {
editorHasBlockWithType(editor, block.type, {
name: "string",
}) &&
event.key === "Enter"
event.key === "Enter" &&
!event.nativeEvent.isComposing
) {
event.preventDefault();
editor.updateBlock(block.id, {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/LinkToolbar/EditLinkMenuItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const EditLinkMenuItems = (

const handleEnter = useCallback(
(event: KeyboardEvent) => {
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
event.preventDefault();
editLink(validateUrl(currentUrl), currentText, props.range.from);
props.setToolbarOpen?.(false);
Expand Down
4 changes: 2 additions & 2 deletions packages/xl-ai/src/components/AIMenu/PromptSuggestionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const PromptSuggestionMenu = (props: PromptSuggestionMenuProps) => {

const handleEnter = useCallback(
async (event: KeyboardEvent) => {
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
// console.log("ENTER", currentEditingPrompt);
onManualPromptSubmit(promptTextToUse);
}
Expand Down Expand Up @@ -71,7 +71,7 @@ export const PromptSuggestionMenu = (props: PromptSuggestionMenuProps) => {
const handleKeyDown = useCallback(
(event: KeyboardEvent) => {
// TODO: handle backspace to close
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
if (items.length > 0) {
handler(event);
} else {
Expand Down
Loading