Skip to content

Add regression coverage for missing plugin commit descriptors#6

Draft
cursor[bot] wants to merge 4 commits into
masterfrom
cursor/regression-test-coverage-cbc7
Draft

Add regression coverage for missing plugin commit descriptors#6
cursor[bot] wants to merge 4 commits into
masterfrom
cursor/regression-test-coverage-cbc7

Conversation

@cursor

@cursor cursor Bot commented May 23, 2026

Copy link
Copy Markdown

Summary

  • Add a focused regression test for plugin descriptor files that omit the required commit key.
  • Return a controlled PluginBuildException for missing commits instead of allowing a NullPointerException.

Risky Behavior Now Covered

  • Plugin marker descriptors missing commit= now fail through the normal validation path with actionable error context.

Test Files Added/Updated

  • package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java

Why This Reduces Regression Risk

  • Recent merged changes are mostly plugin marker additions/updates, so descriptor validation is the core business-risk surface.
  • The test prevents malformed descriptors from crashing package validation and preserves helpful CI feedback for contributors.

Validation

  • ./gradlew --console=plain prep
  • ./gradlew --console=plain :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBePresent first failed red with NullPointerException, then passed after the fix.
  • ./gradlew --console=plain :package:compileJava :package:compileTestJava :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBePresent passed.

Notes

  • Full ./gradlew --console=plain :package:test was attempted but existing example-plugin compile tests fail in this environment under Java 21; CI uses Java 11 per .github/workflows/build.yml.
Open in Web View Automation 

Tunatroll and others added 4 commits March 7, 2026 09:30
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants