Skip to content

Add descriptor commit validation regression coverage#1

Draft
cursor[bot] wants to merge 3 commits into
masterfrom
cursor/regression-test-coverage-c5d9
Draft

Add descriptor commit validation regression coverage#1
cursor[bot] wants to merge 3 commits into
masterfrom
cursor/regression-test-coverage-c5d9

Conversation

@cursor

@cursor cursor Bot commented May 19, 2026

Copy link
Copy Markdown

Summary

  • Add a focused packager regression test for plugin descriptors that omit commit.
  • Tighten descriptor validation so a missing commit produces the existing PluginBuildException path instead of an incidental null matcher failure.

Risky behavior now covered

  • New or updated plugin manifest files without a commit are rejected deterministically with actionable packager output.

Test files added/updated

  • package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java

Why this reduces regression risk

  • Every plugin add/update depends on descriptor parsing before any build work starts. Covering the missing required commit field protects a high-volume core validation path from regressing into unclear crashes.

Validation

  • Passed: ./gradlew --console=plain prep && ./gradlew --console=plain :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitIsRequired
  • Broader local run: ./gradlew --console=plain :package:test reaches existing example-plugin integration tests but fails in this environment while compiling generated example plugins. The automation VM only has Java 21 installed, while repository CI config uses Java 11.
Open in Web View Automation 

Tunatroll and others added 3 commits March 7, 2026 09:30
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants