Add descriptor commit validation regression coverage#1
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit.commitproduces the existingPluginBuildExceptionpath instead of an incidental null matcher failure.Risky behavior now covered
commitare rejected deterministically with actionable packager output.Test files added/updated
package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.javaWhy this reduces regression risk
commitfield protects a high-volume core validation path from regressing into unclear crashes.Validation
./gradlew --console=plain prep && ./gradlew --console=plain :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitIsRequired./gradlew --console=plain :package:testreaches existing example-plugin integration tests but fails in this environment while compiling generated example plugins. The automation VM only has Java 21 installed, while repository CI config uses Java 11.