Skip to content

Added gitignore and path for logging package test files#477

Merged
9larsons merged 1 commit intomainfrom
fix-logging-files
Mar 24, 2026
Merged

Added gitignore and path for logging package test files#477
9larsons merged 1 commit intomainfrom
fix-logging-files

Conversation

@9larsons
Copy link
Collaborator

@9larsons 9larsons commented Mar 24, 2026

no ref

Occasionally we'd have files hanging around from canceled test runs and the like. This pushes the files to a more specific directory and adds a gitignore rule for it.

@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20411ad8-0bb4-4b88-ab00-b8b0dc7b0c59

📥 Commits

Reviewing files that changed from the base of the PR and between fba0896 and 2452037.

📒 Files selected for processing (2)
  • .gitignore
  • packages/logging/test/logging.test.js

Walkthrough

This pull request adds a test artifacts directory to .gitignore and refactors the logging test suite to use centralized helper functions for managing test log directories. New helpers prepareTestLogDir() and getTestLogDir() were introduced to replace hardcoded relative paths. Multiple test cases were updated to use these helpers, with cleanup logic modernized from rimraf to fs.rmSync() and one test converted to async/await pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding a gitignore entry and adjusting paths for logging package test artifact directories.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for organizing test files into a specific directory and adding gitignore rules.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-logging-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) March 24, 2026 13:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (fba0896) to head (2452037).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         127      127           
  Lines        6404     6404           
  Branches     1228     1227    -1     
=======================================
  Hits         6355     6355           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit 8e881ad into main Mar 24, 2026
4 checks passed
@9larsons 9larsons deleted the fix-logging-files branch March 24, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants