Fix PostgreSQL index names and bootstrap races - #51
Merged
Merged
Conversation
Benchmark comparisonThreshold: ±25% (informational, does not block merge)
|
This was referenced Oct 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated PostgreSQL compound index names could exceed PostgreSQL's 63-byte identifier limit, causing important typed unique indexes to be skipped. Concurrent first use could also race while creating the same collection table and fail with a duplicate type error.
This change retains existing short index names, uses a stable digest for longer names while preserving the suffix, and serializes first-use schema creation per collection. It updates the PostgreSQL contract and changelog.
Validation
check json...............................................................Passed
trim trailing whitespace.................................................Passed
black....................................................................Passed
isort....................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Passed
Detect Secrets...........................................................Passed
One initial full-suite run reproduced the concurrent bootstrap race; it passed after the per-collection lock was added.