Core/GameObject: Fishing holes with zero min and max success opens should not despawn#31719
Open
offl wants to merge 1 commit intoTrinityCore:3.3.5from
Open
Core/GameObject: Fishing holes with zero min and max success opens should not despawn#31719offl wants to merge 1 commit intoTrinityCore:3.3.5from
offl wants to merge 1 commit intoTrinityCore:3.3.5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Examples:
Huge Runescale Koi School https://www.youtube.com/watch?v=amSD_YUtpC0
Strange Pool https://youtu.be/ejrmOpJQLVg?t=218
Ghostly Queenfish School https://youtu.be/YiF5XoS8NJ4?t=63 (dissapears at the end of the video because player loses buff to see holes)
Not sure how to merge this one, I'm rewriting Lurker and gameobject script requires changes because with this PR gameobject doesn't reset anymore after fishing Lurker, meaning after wipe players will be not able to re-spawn Lurker (caused by return true in go script)
Issues addressed:
none
Tests performed:
builds, tested in-game with few fishing holes