Add ID strings to debugging messages referring to DOM nodes#312
Open
zerodogg wants to merge 2 commits intoTreesaver:masterfrom
Open
Add ID strings to debugging messages referring to DOM nodes#312zerodogg wants to merge 2 commits intoTreesaver:masterfrom
zerodogg wants to merge 2 commits intoTreesaver:masterfrom
Conversation
Can be used to help identify elementents that are being referred to in debugging messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a method to the debug object that generates an identifying string (based on id, data-sizes or class) for a DOM node.
Helps identify which nodes are bing referred to, i.e. in "Zero-height block ignored" messages, so that it's easier to figure out what the problem might be.
becomes
which provides a lot more to go on.
Updated for coding style, and removed useless test for id.