Adding some more elements to PassingTime#1019
Closed
Conversation
Documentation changes in the XSD for `FreeRecharging`, `Cage`, `RemoteControl`, `LocalControl` and `LockingMechanism` Refer to #999 for more details
The SIRI import is probably coming from a SIRI copy/paste since the NeTEx occupancy is following the SIRI one. The NaturalLanguageStringStructure is not NeTEx type, and is only used in this file, and doesn't follow NeTEx style/rules The SIRI import is crashing some generic NeTEx (and SIRI) import in some implementation (one of them being OpRa). The reason for this crash is difficult to analyse (and depending on the validation engine), but basically related to object redefinition. As a result this import was a useless and dangerous breaking change and has to be removed.
* Update changelog * Remove redundancy with readme * Remove duplicates in the changelog details for v1.1.0 * Correct hierarchy of changelog for v1.0.9 and v1.0.8 * Delete change_log.md Remove redundant file * Fix link to CHANGELOG in README * Rename 'Change log' to 'Changelog' * Update README.md Co-authored-by: Thibaut Barrère <thibaut.barrere@gmail.com>
Update typo in the name of elements in the repo
ue71603
added
the
enhancement
Contributor
|
Why not in the ServiceJourneyPattern? |
Contributor
Author
|
wasn't a good fit in my view. Where should I put it in? I would need to put it in PointInJourneyPattern |
Collaborator
|
@ue71603, should not this one target |
Contributor
StopPointInJourneyPattern, then it would be applied to all Journeys = less data to be shipped. |
Contributor
Author
|
continued here: #1020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching from Call to PassingTime we found that we might need some things that don't exist there.
We suggest to add those to PassingTime.
However, we have the problem, that the things are on CallPartStructure as e.e. checkConstraints might be different. We could have an ArrivalCheckConstraint and a DepartureCheckConstraint. What do you think?